Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated SimpleJobLauncher with TaskExecutorJobLauncher #6060

Closed
wants to merge 1 commit into from

Conversation

cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Nov 8, 2024

resolves #6059

@cppwfs cppwfs requested review from corneil and onobc November 8, 2024 23:20
Copy link
Contributor

@corneil corneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cppwfs
Copy link
Contributor Author

cppwfs commented Nov 11, 2024

Thanks for the review @corneil !

Rebased Merged.

@cppwfs cppwfs closed this Nov 11, 2024
@cppwfs
Copy link
Contributor Author

cppwfs commented Nov 11, 2024

Closed in Error.

@cppwfs cppwfs reopened this Nov 11, 2024
@cppwfs
Copy link
Contributor Author

cppwfs commented Nov 12, 2024

Thanks for the review @corneil !

Rebased Merged.

@cppwfs cppwfs closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleJobLauncher is deprecated and needs to be replaced with TaskExecutorJobLauncher
2 participants