Update Task Thin Executions list function for parity with 2.11.x #6063
+32
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated task thin executions link handing and added extra test for parity with 2.11.x See spring-cloud#6062
corneil
added
the
review/at-least-one
Updated task thin executions link handing and added extra test for parity with 2.11.x. Update minimum supported version of client. See spring-cloud#6062
Updated task thin executions link handing and added extra test for parity with 2.11.x. Update minimum supported version of client. See spring-cloud#6062
Updated task thin executions link handing and added extra test for parity with 2.11.x. Update minimum supported version of client. See spring-cloud#6062
cppwfs
requested changes
Nov 12, 2024
...t-client/src/test/java/org/springframework/cloud/dataflow/rest/client/TaskTemplateTests.java
Show resolved
Hide resolved
| validateExecutionLinkPresent("1.8.0"); | ||
| validateExecutionLinkPresent("1.9.0"); | ||
| validateExecutionLinkPresent("2.0.0"); | ||
| validateExecutionLinkPresent("3.0.0"); |
There was a problem hiding this comment.
We probably want to have negative test as well. i.e. test with an old version.
There was a problem hiding this comment.
At the moment we don't have old versions we support with links missing
There was a problem hiding this comment.
I'm thinking of something like:
@Test
void invalidDataFlow() {
assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> validateExecutionLinkPresent("2.11.5"));
}
```
WDYT?
Updated task thin executions link handing and added extra test for parity with 2.11.x. Update minimum supported version of client. Added test for invalid old version. See spring-cloud#6062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated task thin executions link handing and added extra test for parity with 2.11.x
See #6062