Support setting Spring.webflux.base-path and supporting it in path predicate #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Guofuyinan Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Guofuyinan Thank you for signing the Contributor License Agreement! |
I will add a test ASAP |
Guofuyinan
force-pushed
the
main
branch
4 times, most recently
from
920d2ab to
1ceaee8
Compare
spencergibb
requested changes
Jun 21, 2023
...t/java/org/springframework/cloud/gateway/handler/predicate/GatewayPredicateVisitorTests.java
Show resolved
Hide resolved
spencergibb
reviewed
Jun 21, 2023
...main/java/org/springframework/cloud/gateway/handler/predicate/PathRoutePredicateFactory.java
Outdated
Show resolved
Hide resolved
…ath Predicates Return 404 Results Changing the order of imports Revert code style
|
Looks like some checkstyle issues. |
Try again |
|
@spencergibb any update? |
spencergibb
changed the title
|
We will get this included in the 2024.0 release train. |
@spencergibb any update? |
# Conflicts: # spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/config/GatewayAutoConfiguration.java # spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/handler/predicate/PathRoutePredicatePathContainerAttrBenchMarkTests.java # spring-cloud-gateway-server/src/test/java/org/springframework/cloud/gateway/support/tagsprovider/GatewayPathTagsProviderTests.java
# Conflicts: # spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/handler/predicate/PathRoutePredicateFactory.java
|
Fixes #1759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Bug : Setting Spring.webflux.base-path All Path Predicates Return 404 Results
Issues :
New Issue : #2944
Three Years Ago Issue : #1759