add distribute redis rate limiter #3016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caichengw Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@caichengw Thank you for signing the Contributor License Agreement! |
|
@spencergibb @ryanjbaxter Can you review and merge this PR? This PR looks great, and it should be a very efficient rate limiter, since we don't need to send request to Redis for every incoming request. Regards |
kimmking
suggested changes
Jan 14, 2024
| @ConditionalOnBean(ReactiveRedisTemplate.class) | ||
| @ConditionalOnClass({RedisTemplate.class, DispatcherHandler.class}) | ||
| @ConditionalOnProperty(name = "spring.cloud.gateway.redis.enabled", matchIfMissing = true) | ||
| public class GatewayDistributeRedisLimiterAutoConfiguration { |
There was a problem hiding this comment.
how to use a cluster or m-s to avoid single redis node failed?
|
I want to move away from custom rate limiters, see #2955. You're more than welcome to publish it on your own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add one distribute redis rate limiter implement.
reduce interaction on redis in less stringent scenario.