Ssl bundles not working because of wrong condition

[dimitarp]

No description provided.

[pivotal-cla]

@dimitarp Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@dimitarp Thank you for signing the Contributor License Agreement!

[spencergibb]

Can you describe the problem you're having and the purpose of the fix?

You will also need a test that would fail without your change.

[dimitarp]

Thanks for looking at the PR! I've added a new commit with a test, which fails without the fix.

[spencergibb]

Can you describe the problem you're having and the purpose of the fix?

[dimitarp]

Can you describe the problem you're having and the purpose of the fix?

The problem is, that specifying a bundle doesn't work at all. The problem is the following if:

if (ssl.getSslBundle() == null || ssl.getSslBundle().length() > 0) {
    return null;
}

Returning null when the SSL Bundle name is not empty (ssl.getSslBundle().length() > 0) doesn't really make sense ;)

[spencergibb]

There are some checkstyle issue in the tests
https://github.com/spring-cloud/spring-cloud-gateway/actions/runs/12355094917/job/34491931238?pr=3641#step:4:779