Prefix function names with spring-
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Dec 27, 2023
|
Yes, I prefer to have dirs renamed: much easier to comprehend . And no, I don’t see reasons in renaming beans : doesn’t look like Spring Boot has that habit for auto-configured beans. thanks P.S. not sure then what you talk about docs changes… |
This commit renames each submodule in the common, consumer, function and supplier groups with a prefix of `spring-`.
onobc
force-pushed
the
GH-9-prefix-function-artifacts-with-spring
branch
from
91c6835 to
8835071
Compare
This is minimal now (see 2nd commit). However, If we would have renamed the function bean names then this would have been a bigger change as each README lists the bean name to use to get the function injected. |
artembilan
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a prefix of
spring-to the name of each submodule in the common, consumer, and function groups.Resolves #9
ℹ️ @artembilan a couple of points...
ONE: I did not actually rename the folders of the sub-modules as that leads to bit lengthy, repetitive name. However, I am not strongly opposed to doing that if you think it would be better to keep the folder name in sync w/ the artifiactId.
TWO: Should we also rename the bean function names (eg.
aggregatorFunction->springAggregratorFunction)? Even though this will be a major release, by the principal of "Upgrade Empathy" maybe we should leave the function names as-is?TODO