GH-5: Use DebeziumMessageProducer from Spring Integration
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #5 * Expose `enableEmptyPayload` and `headerNamesToMap` configuration properties instead of plain `copyHeaders` * All the logic now is hidden in the `DebeziumMessageProducer` * Clean up tests according to a new code base * Fix warning for the deprecated Debezium properties. Now only one `delete.tombstone.handling.mode` is needed * Optimize the code flow for the `StepVerifier` via conversion pulled up to the `Flux` * Apparently there is some race condition in the `EmbeddedEngine` around stop functionality, so, add `debezium.embedded.shutdown.pause.before.interrupt.ms=500` instead of `5 minutes` by default
onobc
reviewed
Feb 23, 2024
...springframework/cloud/fn/supplier/debezium/it/supplier/DebeziumSupplierIntegrationTests.java
Outdated
Show resolved
Hide resolved
onobc
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Nice work @artembilan ! Using the Spring Integration adapter really removed a ton of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5
enableEmptyPayloadandheaderNamesToMapconfiguration properties instead of plaincopyHeadersDebeziumMessageProducerdelete.tombstone.handling.modeis neededStepVerifiervia conversion pulled up to theFluxEmbeddedEnginearound stop functionality, so, adddebezium.embedded.shutdown.pause.before.interrupt.ms=500instead of5 minutesby default