GH-3: Add tail support for spring-file-supplier
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Mar 18, 2024
...lier/src/main/java/org/springframework/cloud/fn/supplier/file/FileSupplierConfiguration.java
Show resolved
Hide resolved
onobc
reviewed
Mar 18, 2024
...lier/src/main/java/org/springframework/cloud/fn/supplier/file/FileSupplierConfiguration.java
Outdated
Show resolved
Hide resolved
Apparently the `@ConditionalOnProperty(matchIfMissing = true)` means activate when there is or no that property. To disable a bean when any property provided, we need to use an expression against `environment`
onobc
reviewed
Mar 18, 2024
...lier/src/main/java/org/springframework/cloud/fn/supplier/file/FileSupplierConfiguration.java
Outdated
Show resolved
Hide resolved
onobc
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Thanks for the updates @artembilan . Regardless of what you do w/ my latest comment this LGTM.
…ssageSourceConfiguration` class for easier conditional config
onobc
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3