Add service connection from Opentelemetry Collector for Logging #41324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otlp Logging auto-configuration has been added to Spring Boot. This commit adds ConnectionDetails from Docker Compose and Testcontainers.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: enhancement
|
Placing on hold as we'd like to spend a bit of time thinking through our gRPC support across logs, metrics, and tracing. |
mhalbritter
pushed a commit
that referenced
this pull request
Sep 6, 2024
Adds ConnectionDetails from Docker Compose and Testcontainers. See gh-41324
mhalbritter
added a commit
that referenced
this pull request
Sep 6, 2024
|
Thanks @eddumelendez ! Are you interested in working on #42163 ? |
|
Hi @mhalbritter. Yes, I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otlp Logging auto-configuration has been added to Spring Boot. This commit adds ConnectionDetails from Docker Compose and Testcontainers.
Should move classes from
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/logging/opentelemetry/otlp/tospring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/logging/otlp/? For consistency with metrics and tracing?