events landing page #107
Merged
events landing page #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this generally looks fine.
There's a "more" option of making the EventsLandingPage a RoutablePage, which would allow you to have the semester pages living underneath it "properly" (ie, they'd follow if the landing page slug was changed), but as we've discussed, with the existing implementations, this is fine
| ) | ||
|
|
||
| def save(self, *args, **kwargs): | ||
| self.slug = 'events' |
There was a problem hiding this comment.
This will probably work, but get a bit dicey with revisions and things. I'd say leave it for now, but if it gives you trouble, you can follow this pattern of overriding the page form
haydngreatnews
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.