show current page in primary nav #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @register.filter | ||
| def starts_with(value, arg): |
There was a problem hiding this comment.
Wild that this isn't a default tag (given some of the things that are)
| """ | ||
| Return the primary navigation data as a dict, for use with the 'json_script' filter. | ||
| """ | ||
| primary_nav_items = _get_primary_nav_items() | ||
| l1_menu_item_data = [_l1_item_to_dict(item) for item in primary_nav_items] | ||
|
|
||
| current_path = context["request"].path | ||
|
|
||
| for item in l1_menu_item_data: |
There was a problem hiding this comment.
Do we still need to do this, given we've used a different approach in the template?
There was a problem hiding this comment.
If you're asking whether we need it in both the template and the JSON blob, then the answer is yes :/
There was a problem hiding this comment.
Ah, right. In my head we were using the same data for both
haydngreatnews
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.