Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust spacing values to fit more tiles (sometimes) #150

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Adjust spacing values to fit more tiles (sometimes) #150

merged 1 commit into from
Jul 24, 2024

Conversation

liamjohnston
Copy link

Based on client request: https://springload.slack.com/archives/C06P11WJD5Z/p1721707143240949 (private client channel).

@liamjohnston liamjohnston requested a review from a team July 24, 2024 23:10
cameralibre
cameralibre approved these changes Jul 24, 2024
View reviewed changes
Copy link

@cameralibre cameralibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's only gonna have a tiny wee gutter until it reaches the max-content-width? ok, if that's what they want...

@liamjohnston
Copy link
Author

Yep. In reality it's not that noticeable anyway, as most content doesn't occupy the outer columns.

Screenshot 2024-07-25 at 11 27 47 AM

@liamjohnston liamjohnston merged commit deba821 into main Jul 24, 2024
3 of 5 checks passed
@liamjohnston liamjohnston deleted the feature/adjust-sizes-to-fit-more-tiles-sometimes branch July 24, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameralibre cameralibre cameralibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamjohnston @cameralibre