Updating some wording #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamjohnston
reviewed
Aug 8, 2024
| @@ -64,7 +64,7 @@ class AccordionTitles(models.TextChoices): | |||
| CODE = "code", "Code" | |||
| DATA = "data", "Data" | |||
| DOCUMENTATION = "documentation", "Documentation" | |||
| ANALYSIS = "analysis", "Analysis" | |||
| PUBLICATIONS_AND_PRESENTATIONS = "publications_and_presentations", "Publications and Presentations" | |||
There was a problem hiding this comment.
Do we know what their casing preference is?
I've been erring on the side of sentence case (e.g. "Publications and presentations") not title case (e.g. "Publications and presentations"). I think sentence case is becoming more common these days.
There was a problem hiding this comment.
Looking at the strings we have below this one (RELATED_COURSES, PROJECT_PEER_REVIEW) it looks like they're all Title Case, and IIRC, there's a style-guide difference -- For what it's worth, APA recommends title-case for this situation
There was a problem hiding this comment.
So is this OK to be left as it is? @haydngreatnews @liamjohnston
haydngreatnews
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.