Skip to content

Commit

Permalink
fix: separation of rp configs (#433)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Related Issue Or Context
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Otherwise, describe context and motivation for change herre -->

Closes: #<issue>

## How Has This Been Tested? Testing details.
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have ensured that all acceptance criteria (or expected behavior)
from issue are met
- [ ] I have updated the documentation locally and in chainbridge-docs.
- [ ] I have added tests to cover my changes.
- [ ] I have ensured that all the checks are passing and green, I've
signed the CLA bot
  • Loading branch information
saadahmsiddiqui authored Aug 13, 2024
1 parent 2350ec6 commit 1fc3931
Show file tree
Hide file tree
Showing 12 changed files with 50 additions and 72 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
with:
command: manifest
release-type: node
config-file: "release-please/rp-core-config.json"
manifest-file: "release-please/rp-core-manifest.json"
path: "packages/core"
token: ${{secrets.RELEASE_TOKEN}}
monorepo-tags: true
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release-evm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
command: manifest
release-type: node
path: "packages/evm"
config-file: "release-please/rp-evm-config.json"
manifest-file: "release-please/rp-evm-manifest.json"
token: ${{secrets.RELEASE_TOKEN}}
monorepo-tags: true
default-branch: main
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release-substrate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
command: manifest
release-type: node
token: ${{secrets.RELEASE_TOKEN}}
config-file: "release-please/rp-substrate-config.json"
manifest-file: "release-please/rp-substrate-manifest.json"
monorepo-tags: true
default-branch: main
path: "packages/substrate"
Expand Down
18 changes: 0 additions & 18 deletions packages/core/CHANGELOG.md

This file was deleted.

22 changes: 0 additions & 22 deletions packages/substrate/CHANGELOG.md

This file was deleted.

32 changes: 0 additions & 32 deletions release-please-config.json

This file was deleted.

14 changes: 14 additions & 0 deletions release-please/rp-core-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"plugins": ["node-workspace"],
"packages": {
"packages/core": {
"releaseType": "node",
"draft": false,
"prerelease": false,
"bumpMinorPreMajor": false,
"bumpPatchForMinorPreMajor": false,
"changelogPath": "CHANGELOG.md",
"versioning": "default"
}
}
}
1 change: 1 addition & 0 deletions release-please/rp-core-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
14 changes: 14 additions & 0 deletions release-please/rp-evm-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"plugins": ["node-workspace"],
"packages": {
"packages/evm": {
"releaseType": "node",
"draft": false,
"prerelease": false,
"bumpMinorPreMajor": false,
"bumpPatchForMinorPreMajor": false,
"changelogPath": "CHANGELOG.md",
"versioning": "default"
}
}
}
File renamed without changes.
14 changes: 14 additions & 0 deletions release-please/rp-substrate-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"plugins": ["node-workspace"],
"packages": {
"packages/substrate": {
"releaseType": "node",
"draft": false,
"prerelease": false,
"bumpMinorPreMajor": false,
"bumpPatchForMinorPreMajor": false,
"changelogPath": "CHANGELOG.md",
"versioning": "default"
}
}
}
1 change: 1 addition & 0 deletions release-please/rp-substrate-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}

0 comments on commit 1fc3931

Please sign in to comment.