L2CAP Support for ISO 18013-5 Holders #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Currently not working! See below. This provides L2CAP support for the holder for 18013-5. This is disabled at present; the code is in place, but calling connect() on the L2CAP socket throws a "resources not available" exception for reasons I have not yet tracked down. The code should otherwise be ready, however; the request read and the response write are both in place. The presence of an L2CAP characteristic on the peripheral no longer breaks the old flow for the code, so we now properly do non-L2CAP connections to L2CAP peripherals. For convenience, this also includes a makefile to orchestrate building and running; `make` or `make install` will build the example app and attempt to install it on all connected android devices. `make run` will launch the example app on one device and attempt to attach `logcat`. `make help` lists the available commands.
wyc
reviewed
Sep 18, 2024
w4ll3
requested changes
Sep 19, 2024
Ryanmtate
approved these changes
Sep 26, 2024
Ryanmtate
reviewed
Sep 26, 2024
Ryanmtate
reviewed
Sep 26, 2024
This code adds a fallback so that in the event an exception is thrown by the L2CAP socket during connection, it will fall back to the old flow. This is necessary when interacting with the iPhone reader, as Android devices do not seem to get along with BLE link-layer encryption as implemented in iOS.
w4ll3
approved these changes
Oct 1, 2024
sprucekit-mobile-monorepo bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
This adds similiar Android accordion component to iOS to better display Generic Credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides L2CAP support for the holder for 18013-5. Note that when connecting to iOS, calling connect() on the L2CAP socket throws a "resources not available" exception due to (apparently) Android not supporting iOS's implementation of link-layer encryption on L2CAP CoC streams. The Android holder now falls back to the old flow in this case; a corresponding change for the iOS reader will appear shortly to support this in a separate PR.
For convenience, this also includes a makefile to orchestrate building and running;
makeormake installwill build the example app and attempt to install it on all connected android devices.make runwill launch the example app on one device and attempt to attachlogcat.make helplists the available commands.