Add QR Code "scan to share" button that redirects to OID4VP flow #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joey-Silberman
requested review from
Ryanmtate,
timothee-haudebourg and
Juliano1612
Ryanmtate
reviewed
Oct 1, 2024
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
Ryanmtate
approved these changes
Oct 1, 2024
Ryanmtate
reviewed
Oct 1, 2024
| ) { | ||
| Button( | ||
| onClick = { | ||
| navController.navigate(Screen.OID4VPScreen.route) |
There was a problem hiding this comment.
In a follow-up PR, we need to implement the QR code scanner on this page route.
…are button is pressed
Juliano1612
requested changes
Oct 3, 2024
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
| modifier = Modifier.fillMaxSize(), | ||
| contentAlignment = Alignment.BottomCenter | ||
| ) { | ||
| Button( |
There was a problem hiding this comment.
The button is not fixed on the screen. If I add five credentials it disappears
There was a problem hiding this comment.
I think the button should be fixed on the screen now, let me know if it works on your end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the wallet home view (if there are any
rawCredentialson the screen) which redirects to the OID4vp flow. The button will not appear if there are no credentials added yet.I also bumped the CompileSDK version to match the newest version of Android Studio.
Note: This is the Android version of this PR: spruceid/mobile-sdk-ios-app#21