Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #2

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add CI #2

merged 2 commits into from
Jan 12, 2024

Conversation

sbihel
Copy link
Member

@sbihel sbihel commented Jan 12, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Jan 12, 2024

WALL-91 CI for uniffi

  • The Rust layer being mostly a thin wrapper around our libraries which have tests themselves, it should mostly focus on sanity checks that the generated SDKs are behaving correctly.
  • As Swift's packages are git based, it means the generated Swift code will most probably live with the Rust code. If that's the case we can and should check that the generated code is up-to-date.

@sbihel
Remove native kotlin tests
4721244 
They don't work as we only compile for android ABI and they're redundant
with the instrumented/android tests
@sbihel sbihel merged commit a37c9fd into main Jan 12, 2024
3 checks passed
@sbihel sbihel deleted the wall-91-ci-for-uniffi branch January 12, 2024 13:11
sbihel added a commit that referenced this pull request Jan 29, 2024
@sbihel
Add CI (#2)
65384d3 
Also remove native kotlin tests

They don't work as we only compile for android ABI and they're redundant
with the instrumented/android tests
sbihel added a commit that referenced this pull request Jan 29, 2024
@sbihel
Add CI (#2)
1aaf4c3 
Also remove native kotlin tests

They don't work as we only compile for android ABI and they're redundant
with the instrumented/android tests
sbihel added a commit that referenced this pull request May 1, 2024
@sbihel
Add CI (#2)
347a6a6 
Also remove native kotlin tests

They don't work as we only compile for android ABI and they're redundant
with the instrumented/android tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbihel