Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve interoperability issues. #20

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Conversation

cobward
Copy link
Contributor

@cobward cobward commented Sep 5, 2024

  • Added helper functions for initiating the flow from a credential offer.
  • Addressed some nuances of authorization server metadata discovery.
  • Resolved some issues with credential configuration and authorization details parsing.
  • Added support for credential requests by either format or credential_identifier.
  • Added support for multi-credential response from the latest OID4VCI drafts.
  • Added an test that can be used for manual testing against the vc-playground issuer.

Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top notch!

Why the move to singular detail in types? They contain multiple things (e.g. claims) and the specs use plural? (although some of them e.g. only contain a single credential definition so it makes sense)

Cargo.toml Outdated Show resolved Hide resolved
}
}
}
#[serde(untagged)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spicy (I'm just kidding, I don't think there's a good solution here, there's a tradeoff between ease of use/debugging and extensibility, if only there was a good way of getting good error messages with untagged enums...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point. We could maybe write a Deserialize wrapper that includes the format in the error response?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then you would have to do a match on the format or deserialize one by one? I don't know that we can really improve the situation, it is what it is

@cobward
Copy link
Contributor Author

cobward commented Sep 9, 2024

Why the move to singular detail in types? They contain multiple things (e.g. claims) and the specs use plural? (although some of them e.g. only contain a single credential definition so it makes sense)

I wanted to make a distinction between:
AuthorizationDetails -> An array of objects
AuthorizationDetail -> One such object

The spec uses "authorization details object" for one of those objects, so could go for that instead if that's clearer?

@cobward cobward requested a review from sbihel September 9, 2024 10:44
@sbihel
Copy link
Member

sbihel commented Sep 9, 2024

The spec uses "authorization details object" for one of those objects, so could go for that instead if that's clearer?

I like that, but I don't have a strong opinion

@cobward cobward merged commit c5018b6 into main Sep 12, 2024
1 check passed
@cobward cobward deleted the skit-523-oid4vci-interoperability branch September 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants