Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made StringOrURI::as_str public to avoid destructuring inconvenience. #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Made StringOrURI::as_str public to avoid destructuring inconvenience. #524

wants to merge 1 commit into from

Conversation

vdods
Copy link
Contributor

@vdods vdods commented Jul 28, 2023

Seems like leaving it private was a simple oversight.

@vdods
Copy link
Contributor Author

vdods commented Aug 16, 2023

Looks like the build error was error: package time v0.3.24 cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.66.0. This PR shouldn't have an impact on if the build succeeds or not, so it seems like there is a versioning issue (either with time crate or rustc).

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vdods
Copy link
Contributor Author

vdods commented Aug 20, 2024

Same deal here, I sent in a signed CLA Oct 6, 2021, but let me know if you need a new one for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdods @CLAassistant @sbihel