Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new About page with project details and team members #13

Merged
merged 69 commits into from
Oct 26, 2024
Merged

Add new About page with project details and team members #13

merged 69 commits into from
Oct 26, 2024

Conversation

conradolandia
Copy link
Collaborator

@conradolandia conradolandia commented Sep 16, 2024 •
edited
Loading

Created an "About" page with data from our contributors. Also that item was added to the main menu and spacing was standardized for menu items.

TODO:

  • Add page intro text
  • Add big list of contributors text
  • Add Diversity section text
  • Decide what to do about the remaining content and layout suggestions. I would like @ccordoba12's input on this.

@conradolandia
Start creating the About page
0c07121
@conradolandia
Create ContributorCard and implement data fetching for 48 top contrib…
ab58d89 
…utors (divisible by 2 and 3)
@conradolandia
Add some error handling
7080b60
@conradolandia
Add ContributorCard component and disable a line in .gitignore caus…
8f141f8 
…ing issues with the `$lib` directory
@conradolandia
Improve desing and implementation of about page
b7a0567
@conradolandia
Remove number of contributions and add roles to past contributors (as…
d058838 
… a placeholder for now)
@conradolandia
Improve example and remove some unneeded elements
1f61993
@conradolandia
Add past contributors and improve visualization of team members
82adcfa
@conradolandia
Start creating the About page
ede7b3e
@conradolandia
Create ContributorCard and implement data fetching for 48 top contrib…
e5395b4 
…utors (divisible by 2 and 3)
@conradolandia
Add some error handling
55357cb
@conradolandia
Add ContributorCard component and disable a line in .gitignore caus…
c09dad7 
…ing issues with the `$lib` directory
@conradolandia
Improve desing and implementation of about page
79d77a0
@conradolandia
Remove number of contributions and add roles to past contributors (as…
76e81fb 
… a placeholder for now)
@conradolandia
Improve example and remove some unneeded elements
0803ef0
@conradolandia
Add past contributors and improve visualization of team members
395fbf1
@conradolandia
Improve About page, add diversity data and graphic of statisitics. Ad…
7a035d7 
…d menu item, and normalize spacing in header menu
@conradolandia
Solved merge conflicts. Merge branch 'about-page' of https://github.c…
5955124 
…om/conradolandia/spyder-website into about-page
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for spyder-website-preview ready!

Name Link
🔨 Latest commit 13994f8
🔍 Latest deploy log https://app.netlify.com/sites/spyder-website-preview/deploys/671bd7a8c8ee450008e5733d
😎 Deploy Preview https://deploy-preview-13--spyder-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CAM-Gerlach CAM-Gerlach marked this pull request as draft September 17, 2024 23:01
@CAM-Gerlach CAM-Gerlach self-requested a review September 17, 2024 23:01
@CAM-Gerlach CAM-Gerlach added the enhancement New feature or request label Sep 17, 2024
@CAM-Gerlach CAM-Gerlach changed the title About page Add new About page with project details and team members Sep 17, 2024
@CAM-Gerlach CAM-Gerlach requested review from CAM-Gerlach and removed request for CAM-Gerlach September 17, 2024 23:03
CAM-Gerlach
CAM-Gerlach reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout, as far as I can tell, now looks great at different widths down to 320 px. I just have a handful of small textual tweaks and fixes, and one small comment/request. Thanks @conradolandia !

src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
src/routes/about/+page.js Outdated Show resolved Hide resolved
conradolandia and others added 18 commits October 18, 2024 11:58
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
0b24c22 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
e278848 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
4d9699b 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
3351810 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
578d6cd 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
6fca31b 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
502c93d 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
b3a60ec 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
082ec3e 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
d288e7b 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
e857b40 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
52ee285 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
558bae5 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia @CAM-Gerlach
Update src/routes/about/+page.js
a78024f 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@conradolandia
Merge branch 'about-page' of https://github.com/conradolandia/spyder-…
c161813 
…website into about-page
@conradolandia
Accept CAM suggestions for text
ddbb56b
@conradolandia
Merge branch 'main' into about-page
0a0217b
@ccordoba12
Improve one item description for Gonzalo
2821fcb
@ccordoba12
Copy link
Member

ccordoba12 commented Oct 19, 2024 •
edited
Loading

@conradolandia, the text suggestions left by @CAM-Gerlach were for me to review since I was the one that came up with the initial text (fortunately I was ok with most of them, except one that I already fixed). So, please don't be so eager to apply them for next time. Thanks!

In addition, you can add multiple suggestions in a single commit for next time (instead of applying them one by one). That's described here (see Add suggestion to batch), which is also the way we prefer to apply suggestions in all our repos.

@conradolandia
Copy link
Collaborator Author

Thanks @ccordoba12 for the heads up. I did the first one, and then tried the batch, but for some reason, the buttons appeared disabled for me. I will wait for your comments before approving anything.

ccordoba12
ccordoba12 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement, thanks @conradolandia!

@ccordoba12 ccordoba12 merged commit dd54ce8 into spyder-ide:main Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@conradolandia conradolandia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conradolandia @CAM-Gerlach @ccordoba12