Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS feed to the blog #16

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

conradolandia
Copy link
Collaborator

@conradolandia conradolandia commented Sep 19, 2024

This PR improves the following:

  • Add RSS feed at /blog/feed.xml
  • Add linked icon for the RSS feed at the footer
  • Add <link> element in the header of the blog page

Fixes #12

…age, include RSS icon and link in the footer
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for spyder-svelte-website-preview ready!

Name Link
🔨 Latest commit 9e1973f
🔍 Latest deploy log https://app.netlify.com/sites/spyder-svelte-website-preview/deploys/66ebadcc3c436d00084e7ca3
😎 Deploy Preview https://deploy-preview-16--spyder-svelte-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@conradolandia conradolandia self-assigned this Sep 19, 2024
@conradolandia conradolandia added bug Something isn't working enhancement New feature or request labels Sep 19, 2024
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a subject matter expert with the mechanics of the site and upon inspection don't see anything obviously amiss here so I'll defer to your expertise on that @conradolandia . As for the functionality, I don't really use RSS myself nor does my browser support it anymore, but maybe @jondo can do a quick double-check that it works for their use case?

@jondo
Copy link

jondo commented Sep 19, 2024

In the deploy preview this now works fine, thank you!

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, LGTM! Thanks @conradolandia and @jondo !

@CAM-Gerlach CAM-Gerlach merged commit ff3fcf8 into spyder-ide:main Sep 19, 2024
2 checks passed
@conradolandia conradolandia deleted the rss-feed branch September 26, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Spyder Blog's RSS feed is gone
3 participants