-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog from Hendrik (& CAM) on Spyder 6 remote development #35
Add blog from Hendrik (& CAM) on Spyder 6 remote development #35
Conversation
✅ Deploy Preview for spyder-website-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
02e1af9
to
dab6a38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach and @hlouzada for your work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed review @ccordoba12 !
I applied most of the suggestions, some with further modifications, except for:
-
The ones including changing things to first person that weren't originally written that way in the outline and that @hlouzada didn't necessarily say directly himself, which I have no objection to applying so long as he gives his permission firstHe gave permission - The suggestions redundantly adding his name to the beginning of each response that are neither necessary or appropriate for this context and are already covered by your other suggested changes, as explained further in your (first) suggestion of it
- The image replacement suggestions that I was unable to apply as the direct links did not work for me
- A couple other suggestions that appeared to be misunderstandings
Thanks!
Co-authored-by: Carlos Cordoba <[email protected]>
… per approval Co-authored-by: Carlos Cordoba <[email protected]> Co-authored-by: Hendrik <[email protected]>
Hendrik first person suggestions applied per @hlouzada 's permission ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the images I mentioned and responded to @CAM-Gerlach's objections about my initial suggestions.
I replaced the screenshots as requested and also optimized all of them to make them up to several times smaller by reducing unnecessary color depth |
Make the requested and agreed final adjustments. Thanks @ccordoba12 (and @hlouzada , of course) for your feedback! |
73f4198
to
0aa27b6
Compare
0aa27b6
to
913dd42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with this one @CAM-Gerlach and @hlouzada!
@hlouzada and @ccordoba12 will want to review the content first