Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blog post covering Daniel's work on Spyder 6 and beyond #38

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

CAM-Gerlach
Copy link
Member

As the title states; created in cooperation with @dalthviz as well as @ccordoba12

@CAM-Gerlach CAM-Gerlach added the Blog Post A new post to the blog label Dec 13, 2024
@CAM-Gerlach CAM-Gerlach self-assigned this Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for spyder-website-preview ready!

Name Link
🔨 Latest commit d0cac10
🔍 Latest deploy log https://app.netlify.com/sites/spyder-website-preview/deploys/675cc408ada7950008f7af03
😎 Deploy Preview https://deploy-preview-38--spyder-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CAM-Gerlach CAM-Gerlach force-pushed the blog-spyder-6-daniel branch 2 times, most recently from da02875 to d83029c Compare December 13, 2024 01:39
@CAM-Gerlach
Copy link
Member Author

Hey @conradolandia , what's this strange error we're getting only on GitHub Pages that results in the site build failing? It doesn't appear to my eye to have anything to do with the blog page, and it builds just fine on Netlify...I suspect a new version of NodeJS?

file:///home/runner/work/spyder-website/spyder-website/tailwind.config.js:3
const defaultTheme = require("tailwindcss/defaultTheme");
                     ^
ReferenceError: require is not defined
    at file:///home/runner/work/spyder-website/spyder-website/tailwind.config.js:3:22
    at ModuleJobSync.runSync (node:internal/modules/esm/module_job:395:35)
    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:329:47)
    at loadESMFromCJS (node:internal/modules/cjs/loader:1414:24)
    at Module._compile (node:internal/modules/cjs/loader:1[54](https://github.com/spyder-ide/spyder-website/actions/runs/12308033762/job/34352744613?pr=38#step:5:55)7:5)
    at Object..js (node:internal/modules/cjs/loader:1677:16)
    at Module.load (node:internal/modules/cjs/loader:1318:32)
    at Function._load (node:internal/modules/cjs/loader:1128:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:219:24)

Node.js v22.12.0
Error: Process completed with exit code 1.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach and @dalthviz for your work on this!

src/routes/blog/spyder-6-daniel/+page.md Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach for your work on this! Left a couple of comments and I agree with @ccordoba12 ones.

Also, I was a little bit confused for a moment regarding the blog structure since the images for each section come before the section title so for example while I was reading the Spyder Editor migration to new plugin API section I saw this:

image

Which make me think that maybe there was an error with the linked image. To prevent such confusion I would suggest to put first the section name, then the image (if any)

Other than the above this LGTM 👍

src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Show resolved Hide resolved
Copy link
Member Author

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply with revised suggestions to @ccordoba12 and @dalthviz 's reviews.

Was thinking the same about the images; @dalthviz , implemented it in my suggestions as well.

src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
src/routes/blog/spyder-6-daniel/+page.md Outdated Show resolved Hide resolved
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion with what seems like a missing change to address a @ccordoba12 suggestion but leaving approved if you think the current state is the correct one. Thanks again @CAM-Gerlach !

src/routes/blog/spyder-6-daniel/+page.md Show resolved Hide resolved
@conradolandia
Copy link
Collaborator

conradolandia commented Dec 14, 2024

Hey @conradolandia , what's this strange error we're getting only on GitHub Pages that results in the site build failing? It doesn't appear to my eye to have anything to do with the blog page, and it builds just fine on Netlify...I suspect a new version of NodeJS?

Hey @CAM-Gerlach! Yes, it was introduced by a new Node version, they dropped support for CommonJS syntax for imports and instead now we have to use ESM syntax. It is solved by PR #39

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@CAM-Gerlach CAM-Gerlach merged commit abb5c0e into spyder-ide:main Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blog Post A new post to the blog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants