Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] support build with custom (non-standard) functions #320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jan 9, 2020

This is just an idea of how it may be possible to support developers who need to build with non-standard functions. Here is an example where I support UPPER and LOWER functions that can handle many EU characters properly: https://github.com/brodybits/sql.js/tree/custom-eu-string-functions

This idea includes some comments that I think should be considered in src/api.coffee that can help make it easier for people like myself to add custom functions in the future.

I suspect there should be a much smarter way to do this, by using an array of FuncDef structures like they do in extension-functions.c for example.

I will very likely continue with the kind of solution proposed here to support the needs of my customer, with hope for a more standardized solution (someday).

for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript
brodycj referenced this pull request in brodycj/sql.js Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
brodycj referenced this pull request in brodycj/sql.js Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
brodycj referenced this pull request in brodycj/sql.js Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
@brodycj brodycj mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant