Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT [WIP]: Update SQLException to extend android.database.sqlite.SQLiteException #9

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DRAFT [WIP]: Update SQLException to extend android.database.sqlite.SQLiteException #9

wants to merge 1 commit into from

Conversation

brodycj
Copy link

@brodycj brodycj commented Jan 9, 2023

as discussed in: sqlcipher/android-database-sqlcipher#556 - should help improve compatibility with Room API

TODO:

  • Note that this is NOT YET TESTED.

@developernotes
Copy link
Member

Hi @brodybits,

I just pushed up a change to this, but it differs from your pull request. I changed the net.zetetic.SQLException to extend android.database.SQLException instead of RuntimeException. The net.zetetic.database.SQLiteException already extends net.zetetic.SQLException. I have tested this change against the SQLCipher for Android test suite which passes successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brodycj @developernotes