This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Add custom exception class to fix todo from #152 #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -557,7 +557,7 @@ private void checkForComodification() { | |||
| // Return the read element. | |||
| return buffer; | |||
| } catch (IOException e) { | |||
| throw new RuntimeException("todo: throw a proper error", e); | |||
| throw new RuntimeException("Error is occurred while reading object", e); | |||
There was a problem hiding this comment.
should this be a TapeException too?
| /** Thrown when an internal error has occurred in tape lib **/ | ||
| public class TapeException extends RuntimeException { | ||
|
|
||
| private static final long serialVersionUID = 5138225684096988531L; |
There was a problem hiding this comment.
What's this used for?
There was a problem hiding this comment.
Throwable implements Serializable.
That being said, I'd prefer not to empower such usage.
f2prateek
added a commit
that referenced
this pull request
Jul 28, 2018
This is the same as Java 8's [UncheckedIOException](https://docs.oracle.com/javase/8/docs/api/java/io/UncheckedIOException.html). We've copied it so that we can maintain compatibility with Java 7. Other options: * Continue to throw RuntimeException with a nicer error message (i.e. remove the "todo") * Create a custom exception Tape class like we had in tape v1 (ref #154) I think this is nicer than the second as it keeps the ergonomics of Java 8 for those stuck on having to support Java 7.
|
Closed by #193 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains "todo" fixes from issue #152.
Custom exception type
TapeExceptionis introduced to wrap low-levelIOException