Equatable sinks prototype #254
Conversation
| } | ||
| } | ||
|
|
||
| // I guess this could be upstreamed to Blueprint |
There was a problem hiding this comment.
Oh yeah, I think I've seen this go by in POS
There was a problem hiding this comment.
I'm just now noticing that SwiftUI's FocusState is not Equatable. That makes it harder for Views to be Equatable, but I presume SwiftUI's internal comparison of non-Equatable View types handles it well.
| } | ||
| } | ||
|
|
||
| // I guess this could be upstreamed to Blueprint |
There was a problem hiding this comment.
I'm just now noticing that SwiftUI's FocusState is not Equatable. That makes it harder for Views to be Equatable, but I presume SwiftUI's internal comparison of non-Equatable View types handles it well.
| let close: (() -> Void)? | ||
|
|
||
| typealias Output = Never | ||
| enum Output { | ||
| case close | ||
| } |
| } | ||
|
|
||
| struct State { | ||
| var title: String | ||
| var isAllCaps: Bool | ||
| let trampoline = SinkTrampoline() |
There was a problem hiding this comment.
This seems like the best/only way to create a persistent identity that we can use to implement StableSink.== 👍
| let sink = context.makeSink(of: actionType) | ||
|
|
||
| sinks[ObjectIdentifier(actionType)] = sink | ||
|
|
||
| return StableSink(trampoline: self) |
There was a problem hiding this comment.
I wonder if we could pass sink into StableSink.init here and implement StableSink.send using that reference, allowing us to delete sinks, bounce, and destination. That would also avoid retaining any Workflow.Sink that is no longer referenced by any StableSink
Maintaining sinks does add some safety (against this, I think?) by ensuring we use the latest Workflow.Sink that the RenderContext has given us for a given Action type. But not total safety, because we're not evicting from sinks every sink that wasn't remade during the last render.
Is the need for that safety greater when the Rendering holds StableSinks rather than functions closing over Workflow.Sinks?
No description provided.