Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Updates to Improve Clarity #302

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jordangustafson
Copy link
Contributor

This PR updates some comments on testing methods to improve clarity around the expected behavior. It replaces should with will to make it clearer that the provided renderings/outputs will not be validated against the rendering/output of the workflow/worker, but instead they will be stubbed as the rendering/output for the workflow/worker when called.

It also includes some other minor style changes that were picked up by the linter.

Checklist

  • Unit Tests (N/A)
  • UI Tests (N/A)
  • Snapshot Tests (iOS only) (N/A)
  • I have made corresponding changes to the documentation

@jordangustafson jordangustafson requested a review from a team as a code owner September 19, 2024 21:24
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@jordangustafson jordangustafson merged commit 01d8de6 into main Sep 19, 2024
14 checks passed
@jordangustafson jordangustafson deleted the jgustafson/comment-clarity-fix branch September 19, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants