Add maxWarnings config option to allow zero-code exit if number of violations is below a threshold #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olations is below a threshold
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see there's open PR that adds baseline check. This PR addresses same problem: introducing PHPCS to legacy projects where the number of issues is too great to address them immediately.
--max-warningsoption will not silence the issues, the emphasis is on exit-code only.Basically, if there's 50 errors or warnings, providing
--max-warnings=50will allow to still exit with 0.There's a caveat, though: if you a make changes to a file with pre-existing violations, you might want to compensate
--max-warningsvalue by the number of old violations that were fixed(if any) in order to not swallow newly created violations(if any) anywhere in the codebase.