Fixed tests on windows #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
reviewed
Sep 16, 2024
| @@ -56,7 +56,7 @@ class LocationDescriptionDatabase { | |||
| LocationDescriptionDatabase(this.locations); | |||
|
|
|||
| factory LocationDescriptionDatabase.fromString(String data) { | |||
| final lines = data.split('\n'); | |||
There was a problem hiding this comment.
Is this necessary given the fix in tool/encode_tzf.dart?
There was a problem hiding this comment.
Yes, this change modified the line ends from windows convention (CR+LF='\r\n') to Unix (LF only='\n'), before the split on LF only. Without this line there are CR remaining in the strings.
The change in encode_tzf.dart changes backward slashes '' with forward slashes '/' in the names of the timezones. (The backward slashes are coming form the filepaths on windows.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests failed on windows due to incorrect path to data files (starting with /) and missing handling of \r\n