[WIP] Migrate to go mod #626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpordomingo
force-pushed
the
migrate-to-go-mod
branch
2 times, most recently
from
5830d47
to
6eb50cb
Compare
dpordomingo
force-pushed
the
migrate-to-go-mod
branch
from
7e5d9ec
to
03bbabe
Compare
The purpose of Makefile.web is to test and build Lookout web, but it was also testing and building the whole Lookout because Makefile.web includes Makefile, and that one includes src-d/ci/Makefile.main This commit overrides Makefile.main::build, Makefile.main::test and Makefile.main::dependencies targets to avoid calling them when using Makefile.web Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
It will be used `make vendor` to 'tidy', add dependencies into 'vendor' and verify that they matches their integrity checks Signed-off-by: David Pordomingo <[email protected]>
kallax models should be generated with 'make generate-go', kallax migrations should be generated with 'MIGRTION_NAME=<name> make generate-migrations' and packed with 'make pack-migrations' All the code generation: kallax and vendor can be done at once with 'make generate' kallax does not work with go Modules, so it'll be disabled issue: src-d/go-kallax#296 Signed-off-by: David Pordomingo <[email protected]>
dpordomingo
force-pushed
the
migrate-to-go-mod
branch
from
03bbabe
to
8850ecb
Compare
Signed-off-by: David Pordomingo <[email protected]>
Otherwise 'esc' and 'kallax' wont be installed properly and they will be added into 'go.mod' Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Instead of using traditional 'go get', with 'go Modules' it can be locked the tools used by the project in a standard way. Project dependencies will be added into './build/tools/bin' Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
dpordomingo
force-pushed
the
migrate-to-go-mod
branch
from
8403634
to
3869f40
Compare
Signed-off-by: David Pordomingo <[email protected]>
dpordomingo
force-pushed
the
migrate-to-go-mod
branch
from
3869f40
to
123e60d
Compare
Signed-off-by: David Pordomingo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #592
depends on #631
caused by https://github.com/src-d/backlog/issues/1392
blocked by src-d/go-git-fixtures#15
go mod initto creatego.modgo.mod: addreplace github.com/Sirupsen/logrus => github.com/sirupsen/logrus latestgo.mod: addreplace google.golang.org/cloud => cloud.google.com/go latestgithub.com/google/go-githubto begithub.com/google/go-github/v24ingo.modand in all imports of Lookoutgo mod tidygo mod vendorTODO:
building an inventory of dependencies that were automatically added/dropped/updated during the process.