Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Migrate to go mod #626

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[WIP] Migrate to go mod #626

wants to merge 17 commits into from

Commits on Apr 16, 2019

  1. Avoid running Makefile.main ::build ::tests on web 

    The purpose of Makefile.web is to test and build
Lookout web, but it was also testing and building
the whole Lookout because Makefile.web includes
Makefile, and that one includes src-d/ci/Makefile.main

This commit overrides Makefile.main::build,
Makefile.main::test and Makefile.main::dependencies
targets to avoid calling them when using Makefile.web

Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    0e8ea89 View commit details
    Browse the repository at this point in the history

  2. Add .vscode to .gitignore 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    67a8e62 View commit details
    Browse the repository at this point in the history

  3. Create go.mod from Gopkg.lock with 'go mod init' 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    b9988f8 View commit details
    Browse the repository at this point in the history

  4. Fix import route for google/go-github to use module path 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    a07f658 View commit details
    Browse the repository at this point in the history

  5. Bump to go-git-fixtures v3.4 that supports Modules 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    2b3524b View commit details
    Browse the repository at this point in the history

  6. Tidy dependencies with 'go mod tidy' 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    8826fa4 View commit details
    Browse the repository at this point in the history

  7. Fix broken dependencies urls 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    01c70f6 View commit details
    Browse the repository at this point in the history

  8. Update vendor with 'go mod vendor' 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    cba9ab2 View commit details
    Browse the repository at this point in the history

  9. Generate vendor with go Modules 

    It will be used `make vendor` to 'tidy', add dependencies into 'vendor'
and verify that they matches their integrity checks

Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    2fcee77 View commit details
    Browse the repository at this point in the history

  10. Generate kallax files with make targets 

    kallax models should be generated with 'make generate-go',
kallax migrations should be generated with
'MIGRTION_NAME=<name> make generate-migrations' and packed
with 'make pack-migrations'

All the code generation: kallax and vendor can be done
at once with 'make generate'

kallax does not work with go Modules, so it'll be disabled
issue: src-d/go-kallax#296

Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    8850ecb View commit details
    Browse the repository at this point in the history

  11. Avoid running 'Makefile.main::dependencies' which runs go get 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    570b9af View commit details
    Browse the repository at this point in the history

  12. Install $(DEPENDENCIES) with 'go get' instead 'go Modules' 

    Otherwise 'esc' and 'kallax' wont be installed properly
and they will be added into 'go.mod'

Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    5a6a605 View commit details
    Browse the repository at this point in the history

  13. DELETEME patches src-d/go-git-fixtures#15 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    9fd8442 View commit details
    Browse the repository at this point in the history

  14. Use 'go Modules' to fetch $(DEPENDENCIES) 

    Instead of using traditional 'go get', with 'go Modules' it can
be locked the tools used by the project in a standard way.

Project dependencies will be added into './build/tools/bin'

Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    f8f18d1 View commit details
    Browse the repository at this point in the history

  15. Use 'go Modules' and 'vendor' by default 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    43bdcc4 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. DELETEME 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    123e60d View commit details
    Browse the repository at this point in the history

  2. WIP without -mod=vendor 

    Signed-off-by: David Pordomingo <[email protected]>
    @dpordomingo
    dpordomingo committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    f2a6686 View commit details
    Browse the repository at this point in the history