Merge pull request f4exb#1892 from srcejon/fix_1826

M17: Update packet format to comply with current spec
srcejon · Nov 15, 2023 · a4ae0ef · a4ae0ef
2 parents c7eca5e + 5f0d2aa
commit a4ae0ef
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/modemm17/M17Modulator.h b/modemm17/M17Modulator.h
@@ -128,17 +128,13 @@ struct MODEMM17_API M17Modulator
         std::copy(source_.begin(), source_.end(), rit);
 
         lsf[12] = can_ >> 1;
-        lsf[13] = (streamElsePacket ? 5 : 4) | ((can_ & 1) << 7);
+        lsf[13] = (streamElsePacket ? 5 : 2) | ((can_ & 1) << 7);
 
         if (gnss_on_)
         {
             lsf[13] |= (1<<5);
             std::copy(gnss_.begin(), gnss_.end(), &lsf[14]);
         }
-        else
-        {
-            lsf[13] |= (3<<5);
-        }
 
         crc.reset();
 

diff --git a/plugins/channelrx/demodm17/m17demodprocessor.cpp b/plugins/channelrx/demodm17/m17demodprocessor.cpp
@@ -251,10 +251,10 @@ void M17DemodProcessor::decode_type(uint16_t type)
                 m_typeInfo += "UNK";
                 break;
             case 1:
-                m_typeInfo += "RAW";
+                m_typeInfo += "DAT";
                 break;
             case 2:
-                m_typeInfo += "ENC";
+                m_typeInfo += "UNK";
                 break;
             case 3:
                 m_typeInfo += "UNK";

diff --git a/plugins/channeltx/modm17/m17modprocessor.cpp b/plugins/channeltx/modm17/m17modprocessor.cpp
@@ -60,6 +60,7 @@ bool M17ModProcessor::handleMessage(const Message& cmd)
         const MsgSendSMS& notif = (const MsgSendSMS&) cmd;
         QByteArray packetBytes = notif.getSMSText().toUtf8();
         packetBytes.prepend(0x05); // SMS standard type
+        packetBytes.append('\0'); // SMS should be null terminated
         packetBytes.truncate(798); // Maximum packet size is 798 payload + 2 bytes CRC = 800 bytes (32*25)
         processPacket(notif.getSourceCall(), notif.getDestCall(), notif.getCAN(), packetBytes);
         // test(notif.getSourceCall(), notif.getDestCall());

diff --git a/sdrgui/gui/mdiutils.cpp b/sdrgui/gui/mdiutils.cpp
@@ -18,6 +18,7 @@
 #include <QWidget>
 #include <QDebug>
 #include <QDataStream>
+#include <QIODevice>
 
 #include "mdiutils.h"