Merge pull request f4exb#1795 from srcejon/fix_1794

Initialise PhaseDiscriminators state, to avoid outputting huge values.
srcejon · Aug 30, 2023 · f891bd6 · f891bd6
2 parents 2724530 + 313370a
commit f891bd6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/plugins/channelrx/demodpager/pagerdemodgui.cpp b/plugins/channelrx/demodpager/pagerdemodgui.cpp
@@ -819,6 +819,8 @@ void PagerDemodGUI::makeUIConnections()
     QObject::connect(ui->logEnable, &ButtonSwitch::clicked, this, &PagerDemodGUI::on_logEnable_clicked);
     QObject::connect(ui->logFilename, &QToolButton::clicked, this, &PagerDemodGUI::on_logFilename_clicked);
     QObject::connect(ui->logOpen, &QToolButton::clicked, this, &PagerDemodGUI::on_logOpen_clicked);
+    QObject::connect(ui->channel1, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PagerDemodGUI::on_channel1_currentIndexChanged);
+    QObject::connect(ui->channel2, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &PagerDemodGUI::on_channel2_currentIndexChanged);
 }
 
 void PagerDemodGUI::updateAbsoluteCenterFrequency()

diff --git a/sdrbase/dsp/phasediscri.h b/sdrbase/dsp/phasediscri.h
@@ -25,13 +25,25 @@
 class PhaseDiscriminators
 {
 public:
-	/**
+
+    PhaseDiscriminators() :
+        m_fmScaling(1.0f)
+    {
+        reset();
+    }
+
+    /**
 	 * Reset stored values
 	 */
 	void reset()
 	{
 		m_m1Sample = 0;
 		m_m2Sample = 0;
+        m_fltPreviousI = 0.0f;
+        m_fltPreviousQ = 0.0f;
+        m_fltPreviousI2 = 0.0f;
+        m_fltPreviousQ2 = 0.0f;
+        m_prevArg = 0.0f;
 	}
 
 	/**