Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eloquent migration #3

Open
wants to merge 5 commits into
base: eloquent
Choose a base branch
from

Conversation

jginesclavero
Copy link

@jginesclavero jginesclavero commented Sep 2, 2020


Basic Info

Info Please fill out this column
Ticket(s) this addresses Ticket #2
Primary OS tested on Ubuntu 18.04 ROS2 Eloquent
Robotic platform tested on Gazebo simulation of Tutlebot3

Description of contribution in a few bullet points

  • I have migrated Detected person and Tracked persons.
  • I have included some info about the migration in the README.

Screenshot from 2020-08-20 12-23-39

Future work that may be required in bullet points

  • Fix the Person Meshes style because causes a crash.
  • Continue the migration of the rest of the nodes .

@makokal makokal requested a review from tlind September 8, 2020 17:30
Copy link
Member

@makokal makokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work @jginesclavero

##include/spencer_tracking_rviz_plugin/tracked_groups_display.hpp
##include/spencer_tracking_rviz_plugin/social_relations_display.hpp
##include/spencer_tracking_rviz_plugin/social_activities_display.hpp
##include/spencer_tracking_rviz_plugin/human_attributes_display.hpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these left out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @makokal ! I am working on the migration of these nodes, but I preferred do a small PR to easily the revision process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants