Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission kit services VM #68

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

RealOrangeOne
Copy link
Member

This will return for the competition

Summary

:ronseal:

Code review

Testing

  • applied the configuration locally
  • manually validated the new behaviour
  • ... is for chumps

Links

This will return for the competition
@PeterJCLaw
Copy link
Member

@RealOrangeOne as noted elsewhere, please can you test this.

@RealOrangeOne
Copy link
Member Author

$ ./scripts/apply --limit kitsvcs     
[WARNING]: Could not match supplied host pattern, ignoring: kitsvcs
ERROR! Specified inventory, host pattern and/or --limit leaves us with no hosts to target.

Yep, that works.

Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check -- is it intentional that the vagrant config remain in place here? That is: are we expecting that we will want the kit services stuff back sometime soon?

@RealOrangeOne
Copy link
Member Author

The physical server was decommissioned to save costs and maintenance.

This will return for the competition

@RealOrangeOne RealOrangeOne merged commit 8c3cb22 into main Sep 1, 2024
1 check passed
@RealOrangeOne RealOrangeOne deleted the chore/hide-kit-services branch September 1, 2024 18:52
@PeterJCLaw
Copy link
Member

The physical server was decommissioned to save costs and maintenance.

This will return for the competition

🤦 sorry, apparently I'm failing to read this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants