Changed Power test script to use LibUSB #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
reviewed
May 11, 2019
| def __init__(self, device: USBDevice) -> None: | ||
| """Construct power board from `USBDevice`.""" | ||
| self.device = device | ||
| self._configuration: Optional[usb.core.Endpoint] |
There was a problem hiding this comment.
I would enjoy this being compatible with Python 3.5 - remove this line and type annotate via a comment on the next line (add # type: Optional[usb.core.Endpoint] there)
PeterJCLaw
reviewed
May 11, 2019
|
|
||
| This will: | ||
|
|
||
| - hopefully not crash |
There was a problem hiding this comment.
Is there a more useful description we can put here?
| import usb.core | ||
| import usb.util | ||
|
|
||
| class USBDevice(NamedTuple): |
There was a problem hiding this comment.
Would be great if we could make this compatible with Python 3.5 so those of us using Debian stable (or a derivative) can use these scripts.
USBDevice = NamedTuple('USBDevice', (
('serial', str),
('node', usb.core.Device),
('busnum', int),
('devnum', int),
))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.