Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a simple RSS feed for use in Slack #42

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RealOrangeOne
Copy link
Member

This avoids Slack creating verbose posts with links unfurled

The diff here isn't ideal. I didn't rewrite the file, it's just the renaming and the large change makes git think I did.

This avoids Slack creating verbose posts with links unfurled
@RealOrangeOne RealOrangeOne requested a review from a team September 13, 2022 20:53
@PeterJCLaw
Copy link
Member

The diff here isn't ideal. I didn't rewrite the file, it's just the renaming and the large change makes git think I did.

Pro-tip: do the rename as a separate commit than the changes which aren't part of the rename. While the overall PR diff would be unchanged it would allow reviewers the choice of reviewing by commit, where the diffs would be more sensible.

scripts/render-feeds.py Outdated Show resolved Hide resolved
scripts/render-feeds.py Outdated Show resolved Hide resolved
RealOrangeOne and others added 2 commits September 13, 2022 22:43
Co-authored-by: Peter Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants