scuttle-shell #260
Closed
scuttle-shell #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptix
commented
Sep 20, 2018
background-process.js
Outdated
| .use(require('ssb-ws')) | ||
| // .use(require('ssb-mutual')) // this is has recursion problems atm | ||
| // Check if scuttle-shell is already running | ||
| // TODO - make this check for scuttle-shell specifically (and not just an sbot) |
There was a problem hiding this comment.
@mixmix I'm also not sure about this comment.
How would the shell be different from another sbot with the same plugins?
cryptix
force-pushed
the
scuttle-shell
branch
from
2f8f010 to
2a5c069
Compare
uses [email protected] which is based on sbot@12
this has ssb-about@2 also and uses the new api to get the name for the menu. (cc @mixmix)
cryptix
force-pushed
the
scuttle-shell
branch
from
0140607 to
128614c
Compare
|
Is this branch still the best way to try scuttle-shell? |
|
yes but i've not tried it recently. |
|
I’m using it all the time and rebase it when I see something new intersting. ssb-about@2 should already work for instance. |
|
superseeded by #295 (this branch worked for me and I'll leave it up for people who want to try until the TODOs in the new PR are done.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses [email protected] which is based on sbot@12
@mixmix this was based on your old branch. I'm not sure about two of the deps in the pkg.json I dragged back in (ssb-horcrux and style-resolve).