feat: explicitly specify containerPort in helm chart #1306
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1305
Description
Currently, the deployment from the connaisseur helm chart does not explicitly specify the containerPort. This is usually not a problem, because the port can still be used, even if it is not explicitly named.
Explicitly specifying the port has two benefits:
PodMonitor
from the prometheus operator (which requires the port to be explicitly specified). This helps in working around the issue described in Prometheus cannot connect to/metrics
HTTPS endpoint #709, to scrape metrics even when they are provided via https only.In principle, one could also name the port, but since there is only one exposed port and I did not want to use a generic name like
thePort
, I did not add a port name.Checklist
develop
Chart.yaml
(if necessary)