-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert - Support for authentication when calling receiver endpoint. #560
Open
andreee94
wants to merge
27
commits into
sse-secure-systems:develop
Choose a base branch
from
andreee94:feat/alert-authentication
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c39273f
added support for authentication in the alert (both basic and bearer).
andreee94 1fa0693
added unit tests for alert authentication
andreee94 bd88ef3
updated documentation for alert authentication
andreee94 1c3d61e
fixed yq command in makefile
andreee94 3de5ef9
added support for authentication in the alert (both basic and bearer).
andreee94 51ea8a4
added unit tests for alert authentication
andreee94 9a10f8f
updated documentation for alert authentication
andreee94 d771c5e
Merge remote-tracking branch 'refs/remotes/origin/feat/alert-authenti…
andreee94 7613ba3
Improved alert class accordingly to the pull request
andreee94 3d383a5
Updated alert documentation
andreee94 7957567
Renamed authorization_prefix to authentication_scheme in the alert_sc…
andreee94 f96b907
Testing authentication_scheme validation in alert.
andreee94 be8c718
added support for authentication in the alert (both basic and bearer).
andreee94 cec1a0f
added unit tests for alert authentication
andreee94 8050102
updated documentation for alert authentication
andreee94 c04c902
Improved alert class accordingly to the pull request
andreee94 d98c6bd
Updated alert documentation
andreee94 a34506d
Renamed authorization_prefix to authentication_scheme in the alert_sc…
andreee94 14f58cd
Testing authentication_scheme validation in alert.
andreee94 dffbd88
Merge remote-tracking branch 'refs/remotes/origin/feat/alert-authenti…
andreee94 b3a54c0
Code updated to fix pylint suggestions, and other minor changes.
andreee94 0f26f6d
Embracing the EAFP paradigm.
andreee94 0a8b73b
Merge branch 'develop' into feat/alert-authentication
andreee94 b207360
Merge branch 'develop' into feat/alert-authentication
andreee94 826c78e
Moving the alert webhook authentication documentation in the addition…
andreee94 f4d02bb
Improved the helm chart to reference existing secrets and config maps…
andreee94 6aa67ab
Merge remote-tracking branch 'refs/remotes/origin/feat/alert-authenti…
andreee94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the second argument here?
self.authentication_scheme
would beNone
at this point, which is the default fordict.get
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it should take the default value set in the classes that inherited the base.
This is a very bad coded concept, but it should work:
Which prints:
A proper nit-picking review is a great opportunity to improve my coding skills ;)