feat(workflows): Prevent skipped jobs from stopping downstream jobs -- 3

ssi-dk · Oct 4, 2024 · 3fc8ab8 · 3fc8ab8
1 parent c9530b1
commit 3fc8ab8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 20 deletions.
diff --git a/.github/workflows/document.yaml b/.github/workflows/document.yaml
@@ -4,9 +4,6 @@
 on:
   workflow_call:
     inputs:
-      skip:
-        type: boolean
-        default: false
       branch_name:
         type: string
         required: true
@@ -16,7 +13,6 @@ jobs:
   document:
     name: 📖 Document
     runs-on: ubuntu-latest
-    if: ${{ inputs.skip == 'false' }}
 
     steps:
       - name: Checkout repo

diff --git a/.github/workflows/render-readme.yaml b/.github/workflows/render-readme.yaml
@@ -1,9 +1,6 @@
 on:
   workflow_call:
     inputs:
-      skip:
-        type: boolean
-        default: false
       branch_name:
         type: string
         required: true
@@ -12,7 +9,6 @@ jobs:
   render:
     name: 📖 README
     runs-on: ubuntu-latest
-    if: ${{ inputs.skip == 'false' }}
 
     steps:
       - name: Checkout repo

diff --git a/.github/workflows/update-lockfile.yaml b/.github/workflows/update-lockfile.yaml
@@ -1,9 +1,6 @@
 on:
   workflow_call:
     inputs:
-      skip:
-        type: boolean
-        default: false
       cache_version:
         type: string
         default: '1'
@@ -15,7 +12,6 @@ jobs:
   update-lockfile:
     name: 🛠️ Store dependency versions
     runs-on: ubuntu-latest
-    if: ${{ inputs.skip == 'false' }}
 
     steps:
       - name: Checkout repo

diff --git a/.github/workflows/workflow-dispatcher.yaml b/.github/workflows/workflow-dispatcher.yaml
@@ -196,8 +196,8 @@ jobs:
   update-lockfile:
     needs: trigger
     uses: ./.github/workflows/update-lockfile.yaml
+    if: ${{ needs.trigger.outputs.update-lockfile == 'true' }}
     with:
-      skip: ${{ needs.trigger.outputs.update-lockfile == 'false' }}
       cache_version: ${{ needs.trigger.outputs.cache_version }}
       branch_name: ${{ needs.trigger.outputs.branch_name }}
     secrets: inherit
@@ -209,8 +209,8 @@ jobs:
   document:
     needs: [trigger, update-lockfile]
     uses: ./.github/workflows/document.yaml
+    if: always() && ${{ needs.trigger.outputs.document == 'true' }}
     with:
-      skip: ${{ needs.trigger.outputs.document == 'false' }}
       branch_name: ${{ needs.trigger.outputs.branch_name }}
     secrets: inherit
     concurrency:
@@ -221,8 +221,8 @@ jobs:
   render-readme:
     needs: [trigger, update-lockfile]
     uses: ./.github/workflows/render-readme.yaml
+    if: always() && ${{ needs.trigger.outputs.render-readme == 'true' }}
     with:
-      skip: ${{ needs.trigger.outputs.render-readme == 'false' }}
       branch_name: ${{ needs.trigger.outputs.branch_name }}
     secrets: inherit
     concurrency:
@@ -232,20 +232,20 @@ jobs:
 
   lint:
     needs: [trigger, update-lockfile, document, render-readme]
-    if: ${{ needs.trigger.outputs.lint == 'true' }}
+    if: always() && ${{ needs.trigger.outputs.lint == 'true' }}
     uses: ./.github/workflows/lint.yaml
 
 
   spell-checker:
     needs: [trigger, update-lockfile, document, render-readme]
-    if: ${{ needs.trigger.outputs.spell-checker == 'true' }}
+    if: always() && ${{ needs.trigger.outputs.spell-checker == 'true' }}
     uses: ./.github/workflows/spell-checker.yaml
     secrets: inherit
 
 
   R-CMD-check:
     needs: [trigger, update-lockfile, document, render-readme]
-    if: ${{ needs.trigger.outputs.R-CMD-check == 'true' }}
+    if: always() && ${{ needs.trigger.outputs.R-CMD-check == 'true' }}
     uses: ./.github/workflows/R-CMD-check.yaml
     with:
       rcmdcheck_args: ${{ inputs.rcmdcheck_args }}
@@ -258,7 +258,7 @@ jobs:
 
   code-coverage:
     needs: [trigger, update-lockfile, document, render-readme]
-    if: ${{ needs.trigger.outputs.code-coverage == 'true' }}
+    if: always() && ${{ needs.trigger.outputs.code-coverage == 'true' }}
     uses: ./.github/workflows/code-coverage.yaml
     with:
       cache_version: ${{ needs.trigger.outputs.cache_version }}
@@ -273,7 +273,7 @@ jobs:
 
   pkgdown:
     needs: [trigger, update-lockfile, document, render-readme]
-    if: ${{ needs.trigger.outputs.pkgdown == 'true' }}
+    if: always() && ${{ needs.trigger.outputs.pkgdown == 'true' }}
     uses: ./.github/workflows/pkgdown.yaml
     with:
       event_name: ${{ inputs.event_name }}