Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shutdown = TRUE argument for DuckDB #154

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Remove shutdown = TRUE argument for DuckDB #154

merged 3 commits into from
Oct 4, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Oct 4, 2024 •
edited
Loading

Intent

Since DuckDB v0.10.1, the shutdown = TRUE argument is no longer needed, so we remove it from our code base.

Approach

N/A

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Oct 4, 2024
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Oct 4, 2024
@RasmusSkytte RasmusSkytte merged commit e6bdc96 into main Oct 4, 2024
27 checks passed
@RasmusSkytte RasmusSkytte deleted the fix/duckdb_shutdown branch October 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RasmusSkytte RasmusSkytte

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RasmusSkytte