Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dbplyr to handle more of our *_joins #157

Closed
wants to merge 17 commits into from
Closed

Use dbplyr to handle more of our *_joins #157

wants to merge 17 commits into from

Commits on Oct 11, 2024

  1. fix(db_joins): Allow dplyr::join_by as by argument

    @RasmusSkytte
    RasmusSkytte committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    24b67c8 View commit details
    Browse the repository at this point in the history

  2. chore: Update pak.lock

    @RasmusSkytte
    RasmusSkytte committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b3941da View commit details
    Browse the repository at this point in the history

  3. docs(NEWS): Add entry on *_joins fix for dplyr::join_by()

    @RasmusSkytte
    RasmusSkytte committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    01e53e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. fix(db_joins): Remove checkmate checks for dplyr dispatch

    @RasmusSkytte
    RasmusSkytte committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ddb1f54 View commit details
    Browse the repository at this point in the history

  2. test(db_joins): Test all dplyr joins work as expected

    @RasmusSkytte
    RasmusSkytte committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d2c6f7d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. docs(NEWS): Be more precise on when dplyr::join_by() works

    @RasmusSkytte
    RasmusSkytte committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    12e9d06 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. feat(db_joins): Use dbplyr to translate joins

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ec8aabe View commit details
    Browse the repository at this point in the history

  2. test(db_joins): Test that na_by and by arguments are interchangeable … 

    …without NA data
    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bd1817d View commit details
    Browse the repository at this point in the history

  3. fix(db_joins): Match column order with non-overwritten joins

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    01a6c66 View commit details
    Browse the repository at this point in the history

  4. chore(db_joins): Fix lints

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1374723 View commit details
    Browse the repository at this point in the history

  5. docs(db_joins): Update example with dplyr::join_by

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2c178ed View commit details
    Browse the repository at this point in the history

  6. docs(NEWS) Add entry on improved db_joins

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    94cc1df View commit details
    Browse the repository at this point in the history

  7. feat(db_joins): Add extra checkmate checks

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f7c25d7 View commit details
    Browse the repository at this point in the history

  8. fix(db_join): Account for extra args such as copy

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ec4c03b View commit details
    Browse the repository at this point in the history

  9. test(db_join): Remove duplicated test

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6908d7a View commit details
    Browse the repository at this point in the history

  10. chore(db_joins): Add visible binding to modifyList

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e2daf77 View commit details
    Browse the repository at this point in the history

  11. debug(db_joins): Inspect ON query

    @RasmusSkytte
    RasmusSkytte committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c84dffa View commit details
    Browse the repository at this point in the history