Merge pull request #14 from ssi-dk:telkamp7/issue13

Wrap `phi` in `exp()`. Fixes #13
ssi-dk · Nov 29, 2023 · 5f1d2c9 · 5f1d2c9
2 parents a398607 + 8371a63
commit 5f1d2c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/aeddo.R b/R/aeddo.R
@@ -180,7 +180,7 @@ aeddo <- function(
       ncol(reference_design_matrix)
     )]
     # ... and dispersion parameter, phi
-    phi <- optimized_param$par[length(optimized_param$par)]
+    phi <- exp(optimized_param$par[length(optimized_param$par)])
 
     # Establish one-step ahead lambda using reference observation
     lambda <- c(

diff --git a/R/nll_poisson_gamma.R b/R/nll_poisson_gamma.R
@@ -65,7 +65,7 @@ nll_poisson_gamma <- function(
   # Construct vector with fixed effects parameters
   beta <- theta[1:n_parameters]
   # ... and model parameters
-  phi <- theta[-(1:n_parameters)]
+  phi <- exp(theta[-(1:n_parameters)])
 
   # Define the lambda parameter
   lambda <- exp(design_matrix %*% beta - log(n))