Changing threshold and adding functionallity if observables have NA #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SofiaOtero
assigned SofiaOtero, RasmusSkytte and LasseEngboChr and unassigned SofiaOtero
SofiaOtero
added
good first issue
5 tasks
RasmusSkytte
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the disease threshold so it reflects the disease threshold in one time step, when it then is used in the function it is multiplied with the k window parameter that is determined by the user. Fx if it disease_threshold = 20 and k = 5, then the disease_threshold that has to be surpassed in a 5 window time step is 100.
Additionally a functionallity to handle NA values is added. Earlier it was not possible to have NA values in observables. Now a variable na_percentage_allowed can be used to determine how many NA values each window can contain when performing the glm. A test has been added to test its functionallity.
Checklist
NEWS.md