-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add season argument and refactor epi_calendar #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SofiaOtero
force-pushed
the
add_season_argument
branch
from
October 15, 2024 13:04
2475d3b
to
53b4c6d
Compare
SofiaOtero
force-pushed
the
add_season_argument
branch
from
October 16, 2024 08:52
53b4c6d
to
fbe67d4
Compare
SofiaOtero
added
enhancement
New feature or request
refactor
improve code without changing functionality
labels
Oct 16, 2024
RasmusSkytte
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ISO week daye system is not correctly implemented in epi_calender function.
%U: The week number (00–53) of the year (Sunday as the first day of the week).
%V: The ISO 8601 week number (01–53), where Monday is considered the first day of the week. The first week of the year is defined as the week containing the first Thursday of the year.
%Y: Year with century.
%G: The week-based year (see %V) as a decimal number.
Following function is changed to use the ISO numbering with "%V":
The year function does not use ISO either:
current_year <- format(date, "%Y")
meaning that fx date 2018-12-31 will be placed in season 2017/2018 instead of 2018/2019:
Wil be changed to:
This approach correctly captures the ISO year, and ensures alignemnt with the ISO week date system.
Season has been added to the adseo function
Summary now also shows which time interval the observations have.
This PR builds on following PR which needs to be merged before this PR is ready
Checklist
NEWS.md