Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fit_peak feature to be used as dependency for intensity_levels function #35

Merged
merged 21 commits into from
Oct 29, 2024

Conversation

SofiaOtero
Copy link
Contributor

@SofiaOtero SofiaOtero commented Oct 17, 2024

This PR adds the compute_weighted_intensity_levels feature that optimises the intensity levels based on observations and weights from the intensity_level function (to be developed) and the conf_levels and family arguments.

Ouput:
A tibble containing the intensity levels and information about the fit.

Helps resolve part of:

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@SofiaOtero SofiaOtero added the enhancement New feature or request label Oct 18, 2024
@SofiaOtero SofiaOtero self-assigned this Oct 18, 2024
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
R/fit_peak.R Outdated Show resolved Hide resolved
@SofiaOtero SofiaOtero marked this pull request as ready for review October 22, 2024 07:28
@SofiaOtero SofiaOtero mentioned this pull request Oct 22, 2024
6 tasks
R/compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
R/compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
R/compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
R/compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
R/compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
tests/testthat/test-compute_weighted_intensity_levels.R Outdated Show resolved Hide resolved
@SofiaOtero SofiaOtero merged commit 775d406 into master Oct 29, 2024
13 checks passed
@SofiaOtero SofiaOtero deleted the add_peak_algo branch October 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants