Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove badges from functions and rename #38

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

SofiaOtero
Copy link
Contributor

@SofiaOtero SofiaOtero commented Nov 4, 2024

This small PR removes badges from all functions as stable is the default.
The stable badge is normally only used if there is something specific to draw attention to. Badges documentation.

Additionally the PR renames all observed arguments in past tense to observation through all functions.

This PR builds on following PR which needs to be merged before this PR is ready

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@SofiaOtero SofiaOtero self-assigned this Nov 4, 2024
@SofiaOtero SofiaOtero added the documentation Improvements or additions to documentation label Nov 4, 2024
…y_levels

Change function structure (intensity_levels and dependencies)
Copy link
Contributor

@RasmusSkytte RasmusSkytte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I noticed that the "README.Rmd" has "observed" instead of "observation". You may want to change it there as well.

Copy link
Contributor

@RasmusSkytte RasmusSkytte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SofiaOtero SofiaOtero merged commit 8060f88 into master Nov 4, 2024
13 checks passed
@SofiaOtero SofiaOtero deleted the remove_badges branch November 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants