Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add archeoViz-related material #8

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

sebastien-plutniak
Copy link
Contributor

I'm submitting a series of tutorial and class syllabus using the archeoViz application to introduce various concepts regarding digital archaeology.

@nevrome
Copy link
Member

nevrome commented Mar 20, 2024

Cool! I fear, though, that your editor replaced all tabs with one or multiple spaces. And I think our parser may only work with tabs. Could you please adjust this?

@sebastien-plutniak
Copy link
Contributor Author

Ups, thanks, I've corrected the separator!

@nevrome
Copy link
Member

nevrome commented Mar 20, 2024

Hm - OK there seems to be an issue with the automatic validation pipeline.

 -- CORRUPT PACKAGE DATA --------------------------------------------------------
I downloaded the source code for ryannhg/date-format 2.3.0 from:
    https://github.com/ryannhg/date-format/zipball/2.3.0/
But it looks like the hash of the archive has changed since publication:
  Expected: 70c67866fed499bec685f43f23fea279556757f2
    Actual: 86534146f5a550bb8e87b87a7484ea5732090bb5
This usually means that the package author moved the version tag, so report it
to them and see if that is the issue. Folks on Elm slack can probably help as
well.
Error: Process completed with exit code 1.

Some dependency maintainer created a wrong tag on GitHub: ryan-haskell/date-format#40
I'll think about this asap and see if I can fix it on our side.

@nevrome
Copy link
Member

nevrome commented Mar 21, 2024

OK - this issue should be fixed on the main branch now. Could you please merge this main branch again into your fork (I think GitHub calls this to "sync") to finally enable proper validation? Sorry for the hassle.

@nevrome
Copy link
Member

nevrome commented Mar 22, 2024

Great - thanks! We have a properly failing validation run now:

Running 1 tests. To reproduce these results later,
run elm-test-rs with --seed 3475926421 and --fuzz 100
↓ Pseudo-test for teaching material list validation
✗ if the .tsv table can be parsed
    Err "I saw 2 problems while decoding this CSV:\n\nThere was a problem on row 48, in the `Citation` field (column 17): I couldn't find the `Citation` column.\n\nThere was a problem on row 49, in the `Citation` field (column 17): I couldn't find the `Citation` column."
    ╷
    │ Expect.ok
    ╵
    Ok _
TEST RUN FAILED
Duration: 21 ms
Passed:   0
Failed:   1

I think this may be caused by some wrong delimiter. I'll merge now to investigate and fix this.

@nevrome nevrome merged commit cf16c23 into sslarch:main Mar 22, 2024
1 check failed
@nevrome
Copy link
Member

nevrome commented Mar 22, 2024

It was the trailing empty lines at the end of the document.

@sebastien-plutniak
Copy link
Contributor Author

Here we are! Thanks and sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants